Merged
Conversation
JamesNK
added
the
old-area-web-frameworks-do-not-use
ghost
added
the
area-infrastructure
mavasani
reviewed
Dec 14, 2022
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/RouteHandlerAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 14, 2022
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/RouteHandlerAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 14, 2022
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/RouteHandlerAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Dec 14, 2022
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Show resolved
Hide resolved
5 tasks
JamesNK
requested review from
brunolins16,
captainsafia,
halter73 and
mitchdenny
mitchdenny
reviewed
Dec 14, 2022
src/Framework/AspNetCoreAnalyzers/test/RouteHandlers/DetectAmbiguousMappedRoutesTest.cs
Show resolved
Hide resolved
mitchdenny
approved these changes
Dec 14, 2022
Member
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
Certainly a few edge cases I wouldn't have considered testing there!
JamesNK
added
the
blocked
Member
Author
|
Merging blocked until API review is approved. |
JamesNK
force-pushed
the
jamesnk/ambiguous-route-analyzer
branch
from
abd483a to
10be76e
Compare
Youssef1313
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteHandlers/DetectAmbiguousRoutes.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Jan 1, 2023
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Infrastructure/AmbiguousRoutePatternComparer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
JamesNK
removed
the
blocked
Member
Author
|
API review approved, and all current feedback is applied. Any other changes before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45223
Not quite finished. The remaining work:
IEndpointConventionBuilderisn't used to add metadata that could affect routing.RequireAuthorization.It only works with Minimal API. Most of the infrastructure is in place to expand it to analyze controller actions in the future.